feat(ecmascript): PlainTime.prototype.since + until#981
Draft
0Zeno wants to merge 1 commit intotrynova:mainfrom
Draft
feat(ecmascript): PlainTime.prototype.since + until#9810Zeno wants to merge 1 commit intotrynova:mainfrom
0Zeno wants to merge 1 commit intotrynova:mainfrom
Conversation
aapoalas
reviewed
Apr 14, 2026
aapoalas
reviewed
Apr 14, 2026
| // a. If item has an [[InitializedTemporalTime]] internal slot, then | ||
| if let Ok(time) = TemporalPlainTime::try_from(item) { | ||
| // i. Let resolvedOptions be ? GetOptionsObject(options). | ||
| let resolved_options = get_options_object(agent, options, gc.reborrow()).unbind()?; |
Member
There was a problem hiding this comment.
issue: GC can happen on this line and the line below: that would invalidate time. This shouldn't even pass compilation since item should be correctly bound here.
aapoalas
reviewed
Apr 14, 2026
aapoalas
reviewed
Apr 14, 2026
aapoalas
reviewed
Apr 14, 2026
| // 1. Set other to ? ToTemporalTime(other). | ||
| let other = to_temporal_time(agent, other.unbind(), gc.reborrow()); | ||
| // 2. Let resolvedOptions be ? GetOptionsObject(options). | ||
| let resolved_option = get_options_object(agent, options.get(agent), gc.nogc()) |
Member
There was a problem hiding this comment.
nitpick: You can take options here.
aapoalas
changed the title
0Zeno
force-pushed
the
temporal/plaintime-prototype-until-since
branch
from
21b0e9e to
1e33056
Compare
aapoalas
reviewed
Apr 24, 2026
| unsafe { | ||
| plain_time = scoped_instant.take(agent); | ||
| // 1. If options is not present, set options to undefined. | ||
| let options = options.unwrap_or(Value::Undefined); |
Member
There was a problem hiding this comment.
issue: Missing bind call here.
aapoalas
reviewed
Apr 24, 2026
| if let Ok(item) = Object::try_from(item) { | ||
| // a. If item has an [[InitializedTemporalTime]] internal slot, then | ||
| if let Ok(time) = TemporalPlainTime::try_from(item) { | ||
| // i. Let resolvedOptions be ? GetOptionsObject(options). |
Member
There was a problem hiding this comment.
issue: time is invalidated by get_temporal_overflow_option call and would need to be scoped to avoid that problem: better choice is to just get the inner_plain_time value out and store it on the stack here at the entry point of this branch, and return it after we've called get_temporal_overflow_option. A temporal_rs::PlainTime on the stack does not care one whit about / cannot be invalidated by GC.
aapoalas
reviewed
Apr 24, 2026
| // a. If item has an [[InitializedTemporalTime]] internal slot, then | ||
| if let Ok(time) = TemporalPlainTime::try_from(item) { | ||
| // i. Let resolvedOptions be ? GetOptionsObject(options). | ||
| let resolved_options = get_options_object(agent, options, gc.nogc()).unbind()?; |
Member
There was a problem hiding this comment.
issue: Missing .bind() call after .unbind()?.
aapoalas
reviewed
Apr 24, 2026
| // d. Let result be ? ToTemporalTimeRecord(item). | ||
| let result = to_temporal_time_record(agent, item.unbind(), gc.reborrow()).unbind()?; | ||
| // e. Let resolvedOptions be ? GetOptionsObject(options). | ||
| let resolved_options = get_options_object(agent, options, gc.nogc()).unbind()?; |
Member
There was a problem hiding this comment.
issue: Missing .bind() call after .unbind()?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.